Any reason to do it differently?

Sorry for the late reply. Some scripts use this pattern, for instance https://github.com/etcd-io/etcd/blob/main/scripts/update_proto_annotations.sh#L6. I will change it into one line if the file doesn't run strict mode.

side note: fast fail return if there is any error from ./e2e/.... If not, test.sh just reports it fails but no error exit code.

If not, test.sh just reports it fails but no error exit code.

Could you explain this? Isn't it a bug? The script should exit on error, because of set -e

The run_pass is using if to check the command result.

Based on errexit definition, https://www.gnu.org/software/bash/manual/bash.html#The-Set-Builtin

-e
Exit immediately if a pipeline (see Pipelines), which may consist of a single simple command (see Simple Commands), a list (see Lists of Commands), or a compound command (see Compound Commands) returns a non-zero status. The shell does not exit if the command that fails is part of the command list immediately following a while or until keyword, part of the test in an if statement, part of any command executed in a && or || list except the command following the final && or ||, any command in a pipeline but the last, or if the command’s return status is being inverted with !. If a compound command other than a subshell returns a non-zero status because a command failed while -e was being ignored, the shell does not exit. A trap on ERR, if set, is executed before the shell exits.

The shell does not exit if the command that fails is part of the command list immediately following a while or until keyword, part of the test in an if statement, part of any command executed in a && or || list except the command following the final && or ||, any command in a pipeline but the last, or if the command’s return status is being inverted with !.

For example,

➜  ~ cat /tmp/testing.sh
#!/usr/bin/env bash

set -euo pipefail

main() {
  command -v xx # should fail
  command -v ls
}

echo $SHELLOPTS
if ! main; then
  echo oops
fi

main
➜  ~
➜  ~ /tmp/testing.sh
braceexpand:errexit:hashall:interactive-comments:nounset:pipefail
/usr/bin/ls
➜  ~
➜  ~ echo $?
1
➜  ~

So we should add || return if the function has multiple calls 😂

EDIT: change ctr to ls.

Thanks for the clarification.

The exit 255 at line 660 will still exit the script?

Yes. exit 255 will exit the process(script)

Really good catch!! It works after updating your example like below.

#!/usr/bin/env bash

set -euo pipefail

main() {
  command -v xx || return $? # should fail
  command -v ls
}

#echo $SHELLOPTS
if ! main; then
  echo oops
fi
echo $?

main

side note: fast fail return if there is any error during build

side note: go_srcs_in_module doesn't receive any input.